Re: [PATCHv2] Device tree binding for Avago APDS990X light sensor
From: Rob Herring <hidden>
Date: 2018-01-05 16:01:42
Also in:
linux-arm-kernel, linux-omap, lkml
On Tue, Jan 02, 2018 at 01:44:51PM +0100, Pavel Machek wrote:
From: Filip Matijević <redacted> This prepares binding for light sensor used in Nokia N9.
"dt-bindings: ..." is the preferred subject prefix.
quoted hunk ↗ jump to hunk
Signed-off-by: Filip Matijević <redacted> Signed-off-by: Pavel Machek <redacted>diff --git a/Documentation/devicetree/bindings/misc/avago-apds990x.txt b/Documentation/devicetree/bindings/misc/avago-apds990x.txt new file mode 100644 index 0000000..480c0b1 --- /dev/null +++ b/Documentation/devicetree/bindings/misc/avago-apds990x.txt
Put this with other light sensors whether you use IIO or not: bindings/iio/light/
quoted hunk ↗ jump to hunk
@@ -0,0 +1,41 @@ +Avago APDS990X driver
Bindings aren't drivers.
+ +https://docs.broadcom.com/docs/AV02-2867EN + +Required properties: +- compatible: "avago,apds990x" +- reg: address on the I2C bus +- interrupts: external interrupt line number +- vdd-supply: power supply for VDD +- vled-supply: power supply for LEDA +- avago,ga: Glass attenuation
We already have "upisemi,glass-coef". Can we align on something common.
+- avago,cf1: Clear channel factor 1 +- avago,irf1: IR channel factor 1 +- avago,cf2: Clear channel factor 2 +- avago,irf2: IR channel factor 2
Perhaps 2 properties with 2 cells for factor 1 and 2.
+- avago,df: Device factor
Units/range for all these?
+- avago,pdrive: IR current, one of APDS_IRLED_CURR_XXXmA values
Don't we have standard current property for LEDs?
+- avago,ppcount: Proximity pulse count
Is this standard for prox sensors?
+
+Example (Nokia N9):
+
+ als_ps@39 {light-sensor@39
+ compatible = "avago,apds990x"; + reg = <0x39>; + + interrupt-parent = <&gpio3>; + interrupts = <19 (IRQ_TYPE_EDGE_FALLING | IRQ_TYPE_LEVEL_LOW)>; /* gpio_83 */ + + vdd-supply = <&vaux1>; + vled-supply = <&vbat>; + + avago,ga = <168834>; + avago,cf1 = <4096>; + avago,irf1 = <7824>; + avago,cf2 = <877>; + avago,irf2 = <1575>; + avago,df = <52>; + + avago,pdrive = <0x2>; /* APDS_IRLED_CURR_25mA */ + avago,ppcount = <5>; + }; -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html