Hi,

On 01/02/2018 06:27 PM, Sebastian Reichel wrote:

Hi,

On Tue, Jan 02, 2018 at 02:17:22PM +0100, Pavel Machek wrote:

quoted

This adds dts support for magnetometer and touchscreen on Nokia N9.

I think it makes sense to have this splitted.

quoted

Signed-off-by: Pavel Machek <redacted>

diff --git a/arch/arm/boot/dts/omap3-n9.dts b/arch/arm/boot/dts/omap3-n9.dts
index 39e35f8..57a6679 100644
--- a/arch/arm/boot/dts/omap3-n9.dts
+++ b/arch/arm/boot/dts/omap3-n9.dts

@@ -36,6 +57,22 @@
 			};
 		};
 	};
+
+	touch@4b {

touchscreen@

quoted

+		compatible = "atmel,maxtouch";
+		reg = <0x4b>;
+		interrupt-parent = <&gpio2>;
+		interrupts = <29 2>; /* gpio_61, IRQF_TRIGGER_FALLING*/

reset-gpios = <&gpio3 17 GPIO_ACTIVE_SOMETHING>;

I'm using reset-gpios = <&gpio3 17 0>;

quoted

+		vdd-supply = <&vio>;
+		avdd-supply = <&vaux1>;

Those two are not mentioned in the binding and not supported by the
driver as far as I can see?

Right, but vio and vaux1 need to be on - the reason why it's working at
all is because lis302 uses the same regulators and turns them on. IMHO
either we add the support for regulators to maxtouch driver or we add
regulator-always-on to vio and vaux1.

quoted

+	};
+};

Touchscreen with the same settings is required for n950, so it
should be in the shared n950 + n9 file.

As a side-note, there is no pinmux mentioned and usually I'd use
OMAP3_CORE1_IOPAD(0x20c8, PIN_INPUT | MUX_MODE4) /* gpio_61*/
OMAP3_CORE1_IOPAD(0x20f2, PIN_OUTPUT | MUX_MODE4) /* gpio_81*/

For reasons that I can't explain, first line (gpmc_nbe1->gpio_61) breaks
it for me, so I've commented it out. Still, if anyone has an idea what
is wrong with that please let me know.

quoted

+&i2c3 {
+	ak8975@0f {
+		compatible = "asahi-kasei,ak8975";
+		reg = <0x0f>;
+	};
 };

Looking at the N9 board file this is missing a rotation matrix. This
is supported by the binding:

Documentation/devicetree/bindings/iio/magnetometer/ak8975.txt

quoted

 
 &isp {

-- Sebastian

Best regards,
Filip
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html