Re: [PATCH v4 3/3] dt-bindings: iio: temperature: add MLX90632 device bindings

On 12 December 2017 at 18:45, Andreas Färber [off-list ref] wrote:

Am 11.12.2017 um 10:20 schrieb Crt Mori:

quoted

Add device tree bindings for MLX90632 IR temperature sensor.

Signed-off-by: Crt Mori <redacted>
Reviewed-by: Rob Herring <redacted>
---
 .../bindings/iio/temperature/mlx90632.txt          | 28 ++++++++++++++++++++++
 1 file changed, 28 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/iio/temperature/mlx90632.txt

diff --git a/Documentation/devicetree/bindings/iio/temperature/mlx90632.txt b/Documentation/devicetree/bindings/iio/temperature/mlx90632.txt
new file mode 100644
index 000000000000..0b05812001f8
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/temperature/mlx90632.txt

[...]

quoted

+Example:
+
+mlx90632@3a {

Shouldn't the node name be more general like temperature@3a?

None of the current temperature drivers have that, but it would be
nice for portability. I can prepare a patch to fix them all (a quick
check confirmed it is not consistent in pressure and light as well)

quoted

+     compatible = "melexis,mlx90632";
+     reg = <0x3a>;
+};

Also generally the dt-bindings patch should go before the first use of
the compatible string.

OK, will keep in mind in case of v5 to reorder the commits once again.

Best regards,
Crt

Regards,
Andreas

--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)