Re: [PATCH] dt: bindings: as3645a: Fix the example node

On Thu 2017-12-07 09:42:29, Rob Herring wrote:

On Wed, Dec 6, 2017 at 4:32 PM, Dan Murphy [off-list ref] wrote:

quoted

Rob

On 12/06/2017 03:52 PM, Rob Herring wrote:

quoted

On Tue, Dec 05, 2017 at 07:36:37AM -0600, Dan Murphy wrote:

quoted

Fix the address-cells and size-cells example node
to reflect to the correct representation.

Signed-off-by: Dan Murphy <redacted>
---
 Documentation/devicetree/bindings/leds/ams,as3645a.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/leds/ams,as3645a.txt b/Documentation/devicetree/bindings/leds/ams,as3645a.txt
index fdc40e354a64..8a49ccfec29b 100644
--- a/Documentation/devicetree/bindings/leds/ams,as3645a.txt
+++ b/Documentation/devicetree/bindings/leds/ams,as3645a.txt

@@ -59,8 +59,8 @@ Example
 =======

     as3645a@30 {
-            #address-cells: 1
-            #size-cells: 0
+            #address-cells = <1>;
+            #size-cells = <0>;
             reg = <0x30>;
             compatible = "ams,as3645a";

Convention is also we put compatible first.

OK I will move that too for v2.

Can that be in the same patch or do you want a separate patch?

Same patch is fine.

For fixed patch:

Signed-off-by: Pavel Machek <redacted>

Thanks,
								Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html