Re: [PATCH v3 2/3] hwrng: exynos - add Samsung Exynos True RNG driver

It was <2017-12-22 pią 09:35>, when Herbert Xu wrote:

On Fri, Dec 22, 2017 at 09:29:38AM +0100, Marek Szyprowski wrote:

quoted

Hi,

On 2017-12-22 09:24, Herbert Xu wrote:

quoted

On Mon, Dec 04, 2017 at 01:53:50PM +0100, Łukasz Stelmach wrote:

quoted

Add support for True Random Number Generator found in Samsung Exynos
5250+ SoCs.

Signed-off-by: Łukasz Stelmach <redacted>

This doesn't build for me:

  CC [M]  drivers/char/hw_random/exynos-trng.o
../drivers/char/hw_random/exynos-trng.c:230:1: error: \u2018exynos_rng_dt_match\u2019 undeclared here (not in a function)
../drivers/char/hw_random/exynos-trng.c:230:1: error: \u2018__mod_of__exynos_rng_dt_match_device_table\u2019 aliased to undefined symbol \u2018exynos_rng_dt_match\u2019
make[2]: *** [drivers/char/hw_random/exynos-trng.o] Error 1
make[1]: *** [_module_drivers/char/hw_random] Error 2

This looks like a missing dependency on "OF" when "COMPILE_TEST" is
selected.

Actually it looks like a typo.  The variable is actually called
exynos_trng_dt_match as opposed to exynos_rng_dt_match.

Indeed. Honestly, I haven't seen this problem, not even once. Right, I
have never compiled it as a module. Thanks for spotting.

-- 
Łukasz Stelmach
Samsung R&D Institute Poland
Samsung Electronics