Thread (1 message) 1 message, 1 author, 2017-12-18

Re: [PATCH v2] arm: kirkwood: dts: Use lower case for bindings notation

From: Gregory CLEMENT <hidden>
Date: 2017-12-18 16:46:12
Also in: linux-arm-kernel, lkml

Hi Mathieu,
 
 On ven., déc. 15 2017, Andrew Lunn [off-list ref] wrote:
On Fri, Dec 15, 2017 at 06:07:11PM +0100, Mathieu Malaterre wrote:
quoted
Improve the DTS files using lower case to fix the following dtc warnings:

Warning (simple_bus_reg): Node /XXX@<UPPER> simple-bus unit address format error, expected "<lower>"

Converted using the following command:

find . -type f \( -iname *.dts -o -iname *.dtsi \) -exec sed -i -e "s/@\([0-9a-fA-FxX\.;:#]+\)\s*{/@\L\1 {/g" -e "s/@0x\(.*\) {/@\1 {/g" -e "s/@0+\(.*\) {/@\1 {/g" {} +^C

For simplicity, two sed expressions were used to solve each warnings separately.

To make the regex expression more robust a few other issues were resolved,
namely setting unit-address to lower case, and adding a whitespace before the
the opening curly brace:

https://elinux.org/Device_Tree_Linux#Linux_conventions

This is a follow up to commit 4c9847b7375a ("dt-bindings: Remove leading 0x from bindings notation")

Reported-by: David Daney <redacted>
Suggested-by: Rob Herring <robh@kernel.org>
Signed-off-by: Mathieu Malaterre <redacted>
Thanks for fixing up the commit message.

Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Applied on mvebu/dt

Thanks,

Gregory
    Andrew
-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help