Re: [PATCH 1/7] soc: mediatek: Add USB wakeup driver
From: Rob Herring <hidden>
Date: 2017-12-15 20:55:55
Also in:
linux-arm-kernel, linux-mediatek, linux-usb, lkml
On Sat, Dec 09, 2017 at 04:45:30PM +0800, Chunfeng Yun wrote:
This driver is used to support usb wakeup which is controlled by the glue layer between SSUSB and SPM. Usually the glue layer is put into a system controller, such as pericfg module, which is represented by a syscon node in DTS. Due to the glue layer may vary on different SoCs, it's useful to extract a separated driver to simplify usb controller drivers. Signed-off-by: Chunfeng Yun <chunfeng.yun-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> --- drivers/soc/mediatek/Kconfig | 8 + drivers/soc/mediatek/Makefile | 1 + drivers/soc/mediatek/mtk-usb-wakeup.c | 519 ++++++++++++++++++++++++++ include/dt-bindings/soc/mediatek,usb-wakeup.h | 15 +
This belongs in the binding patch and that should come first.
include/linux/soc/mediatek/usb-wakeup.h | 88 +++++ 5 files changed, 631 insertions(+) create mode 100644 drivers/soc/mediatek/mtk-usb-wakeup.c create mode 100644 include/dt-bindings/soc/mediatek,usb-wakeup.h create mode 100644 include/linux/soc/mediatek/usb-wakeup.h
quoted hunk ↗ jump to hunk
+++ b/drivers/soc/mediatek/mtk-usb-wakeup.c@@ -0,0 +1,519 @@ +/* + * Copyright (c) 2017 MediaTek Inc. + * Author: Chunfeng Yun <chunfeng.yun-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> + * + * SPDX-License-Identifier: GPL-2.0
This should be the first line of the file and use a // style comment. [...]
quoted hunk ↗ jump to hunk
diff --git a/include/dt-bindings/soc/mediatek,usb-wakeup.h b/include/dt-bindings/soc/mediatek,usb-wakeup.h new file mode 100644 index 0000000..2461795 --- /dev/null +++ b/include/dt-bindings/soc/mediatek,usb-wakeup.h@@ -0,0 +1,15 @@ +/* + * Copyright (c) 2017 MediaTek Inc. + * Author: Chunfeng Yun <chunfeng.yun-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> + * + * SPDX-License-Identifier: GPL-2.0
ditto. Except headers use /* */ comments... -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html