Re: [PATCH 08/12] mmc: sdhci-omap: Add support to override f_max and iodelay from pdata
From: Philippe Ombredanne <hidden>
Date: 2017-12-14 14:05:08
Also in:
linux-arm-kernel, linux-mmc, linux-omap, lkml
Kishon, On Thu, Dec 14, 2017 at 2:09 PM, Kishon Vijay Abraham I [off-list ref] wrote:
DRA74x EVM Rev H EVM comes with revision 2.0 silicon. However, earlier versions of EVM can come with either revision 1.1 or revision 1.0 of silicon. The device-tree file is written to support rev 2.0 of silicon. pdata-quirks are used to then override the settings needed for PG 1.1 silicon. PG 1.1 silicon has limitations w.r.t frequencies at which MMC1/2/3 can operate as well as different IOdelay numbers. Add support in sdhci-omap driver to get platform data if available (added using pdata quirks) and override the data (max-frequency and iodelay data) obtained from device tree. Signed-off-by: Kishon Vijay Abraham I <redacted>
<snip>
quoted hunk ↗ jump to hunk
--- /dev/null +++ b/include/linux/platform_data/sdhci-omap.h@@ -0,0 +1,35 @@ +/** + * SDHCI Controller Platform Data for TI's OMAP SoCs + * + * Copyright (C) 2017 Texas Instruments + * Author: Kishon Vijay Abraham I <kishon@ti.com> + * + * This program is free software: you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 of + * the License as published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program. If not, see <http://www.gnu.org/licenses/>. + */
Could you use the new SPDX tags instead of this fine and long boilerplate? See Thomas doc for details [1] [1] https://lkml.org/lkml/2017/12/4/934 Thanks! PS: if you could spread the word out in your team too, this would be much welcomed! -- Cordially Philippe Ombredanne