Re: [PATCH net-next v4 1/4] phylib: Add device reset delay support

Hi Geert,

On 12/07/2017 03:52 PM, Geert Uytterhoeven wrote:

Hi Richard,

On Thu, Dec 7, 2017 at 3:43 PM, Richard Leitner [off-list ref] wrote:

quoted

--- a/drivers/net/phy/mdio_device.c
+++ b/drivers/net/phy/mdio_device.c

@@ -24,6 +24,7 @@
 #include <linux/slab.h>
 #include <linux/string.h>
 #include <linux/unistd.h>
+#include <linux/delay.h>

 void mdio_device_free(struct mdio_device *mdiodev)
 {

@@ -118,8 +119,16 @@ EXPORT_SYMBOL(mdio_device_remove);

 void mdio_device_reset(struct mdio_device *mdiodev, int value)
 {
-       if (mdiodev->reset)
-               gpiod_set_value(mdiodev->reset, value);
+       unsigned int d;
+
+       if (!mdiodev->reset)
+               return;
+
+       gpiod_set_value(mdiodev->reset, value);
+
+       d = value ? mdiodev->reset_delay : mdiodev->reset_post_delay;
+       if (d)
+               usleep_range(d, d + min_t(unsigned int, d / 10, 100));

Oops, I meant "max_t", not "min_t", else the upper limit can be "d + 0",
which is not what we want.

You're right...

Sorry, my fault.

I just copied it over from you suggestion without thinking about it...
So it's definitely my fault too ;-)

I'll wait for some more comments and send a new version next week.

regards;Richard.L
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html