Thread (26 messages) 26 messages, 7 authors, 2017-12-12

Re: [PATCH 3/8] mfd: axp20x: probe axp20x_adc driver for AXP813

From: Chen-Yu Tsai <hidden>
Date: 2017-12-07 08:54:48
Also in: linux-arm-kernel, linux-iio, linux-pm, lkml

On Thu, Dec 7, 2017 at 4:51 PM, Quentin Schulz
[off-list ref] wrote:
Hi Maxime,

On 05/12/2017 09:08, Maxime Ripard wrote:
quoted
On Mon, Dec 04, 2017 at 03:12:49PM +0100, Quentin Schulz wrote:
quoted
This makes the axp20x_adc driver probe with platform device id
"axp813-adc".

Signed-off-by: Quentin Schulz <quentin.schulz-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
---
 drivers/mfd/axp20x.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c
index 2468b43..42e54d1 100644
--- a/drivers/mfd/axp20x.c
+++ b/drivers/mfd/axp20x.c
@@ -878,7 +878,9 @@ static struct mfd_cell axp813_cells[] = {
             .resources              = axp803_pek_resources,
     }, {
             .name                   = "axp20x-regulator",
-    }
+    }, {
+            .name                   = "axp813-adc",
+    },
Any particular reason you're not adding it to the DT?
No, no particular reason. It's just the way it is currently for AXP209
and AXP22x so did the same for AXP813.

I'll add DT "support" in next version for all AXPs supported by this
driver. Or is it worthy of a small separate patch series?
IIRC there's no DT support because there's no need to reference
it in the device tree.

ChenYu
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help