On 28-Nov-17 3:30 PM, Marc Zyngier wrote:

On 25/11/17 19:41, Manikanta Maddireddy wrote:

quoted

On 25-Nov-17 5:25 AM, Thomas Gleixner wrote:

quoted

On Fri, 24 Nov 2017, Manikanta Maddireddy wrote:

Please CC the proper mailing list for irq related changes.

quoted

PCI bus support MSI interrupts, allow PCI host driver to set MSI descriptor
data for an irq.

This is not really an explanation why this export is needed.

Thanks,

	tglx

Updated the commit log with why Tegra PCIe driver is using this function in V2.
Please review.

Well, to review it, I would like to be on Cc.

My current position on this is that if you need to export this function,
then you're using a deprecated API, and you should instead consider
moving to the generic MSI model, which doesn't need any of this.

I've done that a distant past, but never actually published the patch
(not tested it):

https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git/commit/?h=irq/kill-msi-controller&id=83b3602fcee7972b9d549ed729b56ec28de16081

But without seeing the patches, I may be barking up the wrong tree...

Thanks,

	M.

Hi Mark,

I will drop this change from this series and will take up generic MSI work in the next series of changes for pci-tegra driver.
Even without this change, pci-tegra driver will work fine as a builtin module. So other changes can still be reviewed and
can be considered as initial step for adding LKM support for pci-tegra.

Thanks,
Manikanta