Thread (23 messages) 23 messages, 6 authors, 2017-12-11

Re: [PATCH v3 4/4] DTS: Pandora: fix panel compatibility string

From: Tony Lindgren <hidden>
Date: 2017-11-28 16:18:42
Also in: dri-devel, linux-arm-kernel, linux-fbdev, linux-omap, lkml

* H. Nikolaus Schaller [off-list ref] [171128 16:17]:
Hi Tony,
quoted
Am 28.11.2017 um 17:04 schrieb Tony Lindgren [off-list ref]:

* H. Nikolaus Schaller [off-list ref] [171128 15:52]:
quoted
We can remove the unnecessary "omapdss," prefix because
the omapdrm driver takes care of it when matching with
the driver table.
So is this needed as a fix or is this another clean-up?

So is this is really needed as a fix?
Hm. How do you differentiate between "fix" and "cleanup"?
Maybe it is more a wording than a content issue...

For me it is a "fix" because it is semantically wrong to have
a prefix where it is not needed. And "fixing" it changes the
compiler output by 8 bytes.
How about let's call it a "typo fix" then? :)
"Cleanup" would be for me removing whitespace or empty lines
or typos in comments.
quoted
If this is just clean-up, again, please resend once the driver
changes have cleared.
There is no change to the pandora driver involved here. The Pandora
panel driver is already correct. Just the DTS has some redundant
content which should be removed.

So there is no dependency for this patch.
OK please resend separately after the driver changes have merged
then.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help