Re: [PATCH v4 4/5] DTS: gta04: add serdev node for w2sg00x4
From: Tony Lindgren <hidden>
Date: 2017-11-17 17:09:10
Also in:
linux-arm-kernel, linux-omap, lkml
* H. Nikolaus Schaller [off-list ref] [171115 21:41]:
quoted hunk ↗ jump to hunk
GTA04 has a W2SG0004/84 connected to UART2 of the OMAP3 processor. A GPIO can pulse the on/off toggle switch. The VSIM regulator is used to power on/off the LNA of an external active GPS antenna so that a driver can turn the LNA off if GPS is not needed to save battery energy. Signed-off-by: H. Nikolaus Schaller <redacted> --- arch/arm/boot/dts/omap3-gta04.dtsi | 6 ++++++ 1 file changed, 6 insertions(+)diff --git a/arch/arm/boot/dts/omap3-gta04.dtsi b/arch/arm/boot/dts/omap3-gta04.dtsi index 4504908c23fe..e967d738aaaf 100644 --- a/arch/arm/boot/dts/omap3-gta04.dtsi +++ b/arch/arm/boot/dts/omap3-gta04.dtsi@@ -477,6 +477,12 @@ &uart2 { pinctrl-names = "default"; pinctrl-0 = <&uart2_pins>; + + gps: gps { + compatible = "wi2wi,w2sg0004"; + lna-supply = <&vsim>; /* LNA regulator */ + enable-gpios = <&gpio5 17 GPIO_ACTIVE_HIGH>; /* GPIO_145: trigger for turning on/off w2sg0004 */ + }; };
How about move the comment above the node to avoid long lines? Or just change it to gpio_145 for the comment as the property is already enable-gpios? Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html