Thread (19 messages) 19 messages, 8 authors, 2017-10-11

Re: [PATCH 1/3] arm: hisi: add ARCH_MULTI_V5 support

From: Hao Zhang <hidden>
Date: 2017-10-11 05:35:30
Also in: linux-clk

Hi all,
Is there any one working on hi3520dv200 or hi3520dv300?

2016年11月18日星期五,Jiancheng Xue [off-list ref] 写道:
Hi Marty,

On 2016/11/17 11:03, Jiancheng Xue wrote:
quoted
Hi Wei,

On 2016/11/16 17:31, Wei Xu wrote:
quoted
Hi Pan,

On 2016/11/16 8:56, wenpan wrote:
quoted
Hi Marty,
Does this confict with your patch? If not,I hope this could be merged
first.  Besides could you tell me the link to your related patch?
quoted
quoted
This is the link: https://patchwork.kernel.org/patch/9334743/
Could you give your comments on this patch?
If you have any objections to it, please let us know.
quoted
Thank you for offering this.If I want to give some comments on Marty's
patch,
quoted
what should I do?

For Marty's patch, I think there's no need to add specific config item
ARCH_HIxxxx
quoted
for every chipset. Some existing chipsets depend on ARCH_HISI directly
like Hi3519
quoted
and Hi3798CV200. If some options like ARM_GIC is removed from ARCH_HISI,
this kind
quoted
of chipsets will must choose other place to select it. I suggest we
should keep selecting
quoted
ARM_GIC under ARCH_HISI as Pan's patch do.

The code may be like this:

config ARCH_HISI
      bool "Hisilicon SoC Support"
-     depends on ARCH_MULTI_V7
+     depends on ARCH_MULTI_V5 || ARCH_MULTI_V6 || ARCH_MULTI_V7
      select ARM_AMBA
-     select ARM_GIC
+     select ARM_GIC if ARCH_MULTI_V7
+     select ARM_VIC if ARCH_MULTI_V5 || depends on ARCH_MULTI_V6
      select ARM_TIMER_SP804
      select POWER_RESET
      select POWER_RESET_HISI
      select POWER_SUPPLY
What's your opinion about this?

Best Regards,
Jiancheng
quoted
quoted
quoted
On 2016/10/17 21:48, Arnd Bergmann wrote:
quoted
On Monday, October 17, 2016 8:07:03 PM CEST Pan Wen wrote:
quoted
Add support for some HiSilicon SoCs which depend on ARCH_MULTI_V5.

Signed-off-by: Pan Wen <wenpan@hisilicon.com <javascript:;>>
Looks ok. I've added Marty Plummer to Cc, he was recently proposing
patches for Hi3520, which I think is closely related to this one.
Please try to work together so the patches don't conflict. It should
be fairly straightforward since you are basically doing the same
change here.


.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org <javascript:;>
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help