Re: [PATCH v16 02/32] v4l: async: Don't set sd->dev NULL in v4l2_async_cleanup
From: Niklas Söderlund <hidden>
Date: 2017-10-26 15:23:38
Also in:
linux-acpi, linux-media
On 2017-10-26 10:53:12 +0300, Sakari Ailus wrote:
v4l2_async_cleanup() is called when the async sub-device is unbound from the media device. As the pointer is set by the driver registering the async sub-device, leave the pointer as set by the driver. Signed-off-by: Sakari Ailus <sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> Reviewed-by: Sebastian Reichel <sebastian.reichel-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org> Acked-by: Hans Verkuil <redacted>
Acked-by: Niklas Söderlund <redacted>
quoted hunk
--- drivers/media/v4l2-core/v4l2-async.c | 1 - 1 file changed, 1 deletion(-)diff --git a/drivers/media/v4l2-core/v4l2-async.c b/drivers/media/v4l2-core/v4l2-async.c index 60a1a50b9537..21c748bf3a7b 100644 --- a/drivers/media/v4l2-core/v4l2-async.c +++ b/drivers/media/v4l2-core/v4l2-async.c@@ -134,7 +134,6 @@ static void v4l2_async_cleanup(struct v4l2_subdev *sd) /* Subdevice driver will reprobe and put the subdev back onto the list */ list_del_init(&sd->async_list); sd->asd = NULL; - sd->dev = NULL; } int v4l2_async_notifier_register(struct v4l2_device *v4l2_dev,-- 2.11.0
-- Regards, Niklas Söderlund -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html