Thread (1 message) 1 message, 1 author, 2017-10-12

Re: [RFC usb-next v5 2/3] usb: core: add a wrapper for the USB PHYs on the root-hub

From: Martin Blumenstingl <hidden>
Date: 2017-10-12 21:08:16
Also in: linux-amlogic

On Sun, Oct 8, 2017 at 11:17 PM, Martin Blumenstingl
[off-list ref] wrote:
[snip]
+struct usb_phy_roothub *usb_phy_roothub_init(struct device *dev)
+{
+       struct device_node *roothub_np, *port_np;
+       struct usb_phy_roothub *phy_roothub;
+       struct usb_phy_roothub *roothub_entry;
+       struct list_head *head;
+       int err;
+
+       roothub_np = usb_of_get_child_node(dev->of_node, ROOTHUB_PORTNUM);
+       if (!of_device_is_available(roothub_np)) {
+               dev_err(dev, "no roothub node found\n");
Xiaolong Ye's kbuild test robot found this dev_err() which shouldn't
be there. I'll remove it in the next version - thanks for spotting
this!
+               return NULL;
+       }
+
[snip]
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help