RE: [PATCH] usb: renesas_usbhs: Add compatible string for r8a7743/5

-----Original Message-----
From: geert.uytterhoeven@gmail.com [mailto:geert.uytterhoeven@gmail.com]
On Behalf Of Geert Uytterhoeven
Sent: 06 October 2017 08:34
To: Biju Das <redacted>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>; Rob Herring
[off-list ref]; Mark Rutland [off-list ref]; Simon
Horman [off-list ref]; Chris Paterson
[off-list ref]; Fabrizio Castro
[off-list ref]; devicetree@vger.kernel.org; Linux-Renesas
[off-list ref]; USB list [off-list ref]
Subject: Re: [PATCH] usb: renesas_usbhs: Add compatible string for r8a7743/5

Hi Biju,

On Thu, Oct 5, 2017 at 5:12 PM, Biju Das [off-list ref] wrote:

quoted

This patch adds support for r8a7743/5 SoC.  The Renesas RZ/G1[ME]
(R8A7743/5) usbhs is identical to the R-Car Gen2 family.

This doesn't change the driver, so it does nothing by itself.  But it
does

Wording it like this may give the wrong impression to the casual reader that a
driver change will be submitted separately.
No driver change is needed due to the fallback compatible value "renesas,rcar-
gen2-usbhs".

quoted

mean that checkpatch won't complain about a future patch that adds
"renesas,usbhs-r8a7743" or "renesas,usbhs-r8a7745" to a DT, which
helps ensure that shipped DTs use documented compatibility strings.

Adding the SoC-specific compatible values here has two purposes:
  1. Document which SoCs have this hardware module,
  2. Allow checkpatch to validate compatible values.

Thanks. I will send  v2 with above changes
 +
Will rebase on the below R-Car D3 patch
https://patchwork.kernel.org/patch/9982267/

regards,
Biju






Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
�{.n�+�������+%��lzwm��b�맲��r��zX���n)���w*jg���
�����ݢj.�۰\��M��gj��a����' ��ޢ�
���j:+v���w�j�m��������zZ+�����ݢj"��!�i