[PATCH 05/12] staging: typec: tcpci: register port before request irq
From: Li Jun <hidden>
Date: 2017-09-26 00:45:20
Subsystem:
staging subsystem, the rest · Maintainers:
Greg Kroah-Hartman, Linus Torvalds
Possibly related (same subject, not in this thread)
- 2017-09-26 · RE: [PATCH 05/12] staging: typec: tcpci: register port before request irq · Jun Li <hidden>
- 2017-09-26 · Re: [PATCH 05/12] staging: typec: tcpci: register port before request irq · Guenter Roeck <hidden>
With that we can clear any pending events and the port is registered so driver can be ready to handle typec events once we request irq. Signed-off-by: Peter Chen <redacted> Signed-off-by: Li Jun <redacted> --- drivers/staging/typec/tcpci.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/typec/tcpci.c b/drivers/staging/typec/tcpci.c
index 0119453..6d608b4 100644
--- a/drivers/staging/typec/tcpci.c
+++ b/drivers/staging/typec/tcpci.c@@ -552,15 +552,14 @@ static int tcpci_probe(struct i2c_client *client, /* Disable chip interrupts */ tcpci_write16(tcpci, TCPC_ALERT_MASK, 0); - err = devm_request_threaded_irq(tcpci->dev, client->irq, NULL, + tcpci->port = tcpm_register_port(tcpci->dev, &tcpci->tcpc); + if (IS_ERR(tcpci->port)) + return PTR_ERR(tcpci->port); + + return devm_request_threaded_irq(tcpci->dev, client->irq, NULL, tcpci_irq, IRQF_ONESHOT | IRQF_TRIGGER_LOW, dev_name(tcpci->dev), tcpci); - if (err < 0) - return err; - - tcpci->port = tcpm_register_port(tcpci->dev, &tcpci->tcpc); - return PTR_ERR_OR_ZERO(tcpci->port); } static int tcpci_remove(struct i2c_client *client)
--
2.6.6
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html