Re: [PATCH v2] iio: proximity: as3935: noise detection + threshold changes

On Sat, 3 Jun 2017 10:00:49 +0100
Jonathan Cameron [off-list ref] wrote:

On Tue, 30 May 2017 16:32:59 -0500
Rob Herring [off-list ref] wrote:

quoted

On Sun, May 28, 2017 at 04:58:30PM +0100, Jonathan Cameron wrote:  

quoted

On Wed, 24 May 2017 22:52:29 -0700
Matt Ranostay [off-list ref] wrote:
    

quoted

Most applications are too noisy to allow the default noise and
watchdog settings, and thus need to be configurable via DT
properties.

Also default settings to POR defaults on a reset, and register
distuber interrupts as noise since it prevents proper usage.

Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Signed-off-by: Matt Ranostay <matt.ranostay-OWPKS81ov/FWk0Htik3J/w@public.gmane.org>    

I wonder if there are many other devices where this sort of
feature is relevant.  Anyone else come across any?

I suppose if we need to modify the ABI for any that show up
in future, it shouldn't be too hard to maintain this one
for backwards compatibility.

Anyhow, new devicetree bindings so I'll give Rob / Mark time
to have a chance to look at it.    

I acked v1.  

Given there are a couple of precursors working their way towards
mainline and stable, I'll need to wait for those to filter through.

Matt give me a bump if it looks like I've forgotten this once
it will apply!

And indeed I forgot it.  A mess up with my local email labelling means
I'm going through the last few months patches making sure I haven't
missed anything.  So far just this one.

Applied to the togreg branch of iio.git with usual push out as testing etc.

Thanks,

Jonathan

Thanks,

Jonathan

quoted

quoted

My immediate thought is that you might be able to do something
a little more user (i.e. devicetree writer) friendly than
just using the register value...    

We certainly don't want that to be the norm, but sometimes it makes 
sense when it's very specific to a certain device.
  

quoted

I see there are values, but it depends on whether the device
is in 'indoor mode' or 'outdoor mode' (which are just gain
settings?).  You could just use them though.

Given the gain is userspace controlled, and seems to effect
the meaning of this setting, is it valid to just put it
in the devicetree?    

--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html