Thread (2 messages) 2 messages, 2 authors, 2017-09-26

Re: [PATCH v13 05/25] v4l: fwnode: Support generic parsing of graph endpoints in a device

From: Laurent Pinchart <hidden>
Date: 2017-09-19 12:34:00
Also in: linux-media

Hi Sakari,

On Tuesday, 19 September 2017 15:11:32 EEST Sakari Ailus wrote:
On Tue, Sep 19, 2017 at 02:35:01PM +0300, Laurent Pinchart wrote:
quoted
On Friday, 15 September 2017 17:17:04 EEST Sakari Ailus wrote:
quoted
Add two functions for parsing devices graph endpoints:
v4l2_async_notifier_parse_fwnode_endpoints and
v4l2_async_notifier_parse_fwnode_endpoints_by_port. The former iterates
over all endpoints whereas the latter only iterates over the endpoints
in a given port.

The former is mostly useful for existing drivers that currently
implement the iteration over all the endpoints themselves whereas the
latter is especially intended for devices with both sinks and sources:
async sub-devices for external devices connected to the device's sources
will have already been set up, or they are part of the master device.
Did you mean s/or they/as they/ ?
No. There are two options here: either the sub-devices a sub-device is
connected to (through a graph endpoint) is instantiated through the async
framework *or* through the master device driver. But not by both of them at
the same time.
The message is then contradicting itself:

"async sub-devices for external devices connected to the device's sources will 
have already been set up, or they are part of the master device."

They refers to "async sub-devices". If they're part of the master device, 
they're not async sub-devices.

-- 
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help