Re: [RESEND PATCH v2 4/6] dt: bindings: as3645a: Improve label documentation, DT example
From: Pavel Machek <hidden>
Date: 2017-09-18 10:56:55
Also in:
linux-leds, linux-media
Hi!
quoted hunk ↗ jump to hunk
Specify the exact label used if the label property is omitted in DT, as well as use label in the example that conforms to LED device naming.@@ -69,11 +73,11 @@ Example flash-max-microamp = <320000>; led-max-microamp = <60000>; ams,input-max-microamp = <1750000>; - label = "as3645a:flash"; + label = "as3645a:white:flash"; }; indicator@1 { reg = <0x1>; led-max-microamp = <10000>; - label = "as3645a:indicator"; + label = "as3645a:red:indicator"; }; };
Ok, but userspace still has no chance to determine if this is flash from main camera or flash for front camera; todays smartphones have flashes on both cameras. So.. Can I suggset as3645a:white:main_camera_flash or main_flash or ....? Thanks, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Attachments
- signature.asc [application/pgp-signature] 181 bytes