Hi Andy,

Sorry missed the 'Suggested-by' tag. Can I resend the v6 with this change, so that Wolfram can pick these patches ?

---
^Divagar

-----Original Message-----
From: Andy Shevchenko [mailto:andy.shevchenko@gmail.com]
Sent: Friday, September 22, 2017 9:42 PM
To: Mani, Rajmohan <redacted>
Cc: Mohandass, Divagar <redacted>;
robh+dt@kernel.org; mark.rutland@arm.com; wsa@the-dreams.de;
sakari.ailus@iki.fi; devicetree@vger.kernel.org; linux-i2c@vger.kernel.org;
linux-kernel@vger.kernel.org; tfiga@chromium.org
Subject: Re: [PATCH v6 2/3] eeprom: at24: add support to fetch eeprom
device property "size"

On Wed, Sep 20, 2017 at 6:52 AM, Mani, Rajmohan
[off-list ref] wrote:

quoted

Adding Tomasz...

Please, don't top post.
Better to resend entire series with all stakeholders included.

quoted

quoted

Obtain the size of the EEPROM chip from DT if the "size" property is
specified for the device.

I guess it lacks
Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Other than that, looks good to me!

Reviewed-by: Andy Shevchenko <redacted>


Wolfram, the binding is ACKed by Rob and this one is in a good shape.
Moreover, it seems like a demand for the property since some IoT stuff
would like to use the driver on ACPI enabled platforms with different sizes.

Can you go ahead and apply first two patches? It would be really appreciated.

quoted

quoted

Signed-off-by: Divagar Mohandass <redacted>
---
 drivers/misc/eeprom/at24.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c

index
764ff5df..2199c42 100644

--- a/drivers/misc/eeprom/at24.c
+++ b/drivers/misc/eeprom/at24.c

@@ -570,6 +570,10 @@ static void at24_get_pdata(struct device *dev,

struct at24_platform_data *chip)
      if (device_property_present(dev, "read-only"))
              chip->flags |= AT24_FLAG_READONLY;

+     err = device_property_read_u32(dev, "size", &val);
+     if (!err)
+             chip->byte_len = val;
+
      err = device_property_read_u32(dev, "pagesize", &val);
      if (!err) {
              chip->page_size = val;
--
1.9.1

--
With Best Regards,
Andy Shevchenko