Re: [PATCH v4 2/6] irqdomain: clear trigger type in irq_domain_push_irq()
From: Marc Zyngier <hidden>
Date: 2017-09-07 12:25:09
Also in:
linux-gpio, lkml
On 07/09/17 12:41, Masahiro Yamada wrote:
quoted hunk ↗ jump to hunk
Prior to the addition of irq_domain_push_irq(), the hierarchy IRQ domain always allocates IRQs from the outer-most domain. Each irqchip usually calls irq_domain_alloc_irqs_parent(), ascending the topology up to the root irqchip. The brand-new function irq_domain_push_irq() allows us to allocate IRQs for parent domain first, then add a child irq_data to the tail of the chain. For the new use-case, if the parent sets a temporary trigger type, it may differ from the type requested to the outer-most irqchip, then irq_create_fwspec_mapping() warns "type mismatch, failed to map..." Clear the trigger type when a new irq_data is connected to the chain. Signed-off-by: Masahiro Yamada <redacted> --- Changes in v4: - Newly added kernel/irq/irqdomain.c | 3 +++ 1 file changed, 3 insertions(+)diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c index da3e0b6..18d11b9 100644 --- a/kernel/irq/irqdomain.c +++ b/kernel/irq/irqdomain.c@@ -1532,6 +1532,9 @@ int irq_domain_push_irq(struct irq_domain *domain, int virq, void *arg) tail_irq_data->chip = NULL; tail_irq_data->chip_data = NULL; + /* clear the trigger type to avoid "type mismatch" error */ + irqd_set_trigger_type(tail_irq_data, IRQ_TYPE_NONE); +
This feels wrong. The initial interrupt hierarchy does have a set trigger, because it has been configured already, and switching it to NONE is hiding the fact that you're setting it to another, conflicting value. Your new fwspec should have a type that is really compatible with with the underlying interrupt, however "temporary". If it is not, you have a problem. Thanks, M. -- Jazz is not dead. It just smells funny...