Re: Applied "regulator: pbias: Select voltage table based on max-voltage" to the regulator tree
From: Mark Brown <broonie@kernel.org>
Date: 2017-09-04 16:48:33
Also in:
linux-arm-kernel, linux-mmc, linux-omap, lkml
On Mon, Sep 04, 2017 at 11:16:54AM +0530, Kishon Vijay Abraham I wrote:
On Friday 01 September 2017 09:53 PM, Mark Brown wrote:
quoted
Hang on, how can this break anything? If it breaks things shouldn't there be bugfixes for incorrect constraints somewhere?
omap_hsmmc sets the pbias voltage to 3V. But here we program the volt table to support either 1.8V or 3.3V (Initially the volt table was programmed to support 3V because of a bug in TRM). So set_voltage of pbias voltage in omap_hsmmc will fail.
Oh, that's appauling. I guess this is some voltage that doesn't get presented to cards because otherwise I'm surprised nobody noticed. Anyway I've dropped the commit from my pull request for now, it'll not go for v4.14, but the pull request is still there.
Attachments
- signature.asc [application/pgp-signature] 488 bytes