Re: [PATCH v2 15/18] clk: add support for clocks provided by SCMI

On 01/09/17 01:19, Stephen Boyd wrote:

On 08/04, Sudeep Holla wrote:

quoted

diff --git a/drivers/clk/clk-scmi.c b/drivers/clk/clk-scmi.c
new file mode 100644
index 000000000000..37f98a6439a0
--- /dev/null
+++ b/drivers/clk/clk-scmi.c

[...]

quoted

+static int scmi_clocks_probe(struct platform_device *pdev)
+{
+	struct device *dev = &pdev->dev;
+	struct device_node *np = dev->of_node;
+	const struct scmi_handle *handle = devm_scmi_handle_get(dev);
+
+	if (IS_ERR_OR_NULL(handle) || !handle->clk_ops)
+		return -EPROBE_DEFER;
+
+	return scmi_clk_add(dev, np, handle);

Why the function? We support more than just platform devices?
Just fold scmi_clk_add() into this function instead please.

All valid points. Fixed locally now, will post as part of next posting
of the series.

-- 
Regards,
Sudeep