Hi Rob,
On 2017-08-22 09:49:35 -0500, Rob Herring wrote:
On Mon, Aug 21, 2017 at 7:19 PM, Niklas Söderlund
[off-list ref] wrote:
quoted
Using CONFIG_OF_DYNAMIC=y uncovered an imbalance in the usecount of the
node being passed to of_fwnode_graph_get_port_parent(). Preserve the
usecount by using of_get_parent() instead of of_get_next_parent() which
don't decrement the usecount of the node passed to it.
Fixes: 3b27d00e7b6d7c88 ("device property: Move fwnode graph ops to firmware specific locations")
Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
drivers/of/property.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Isn't this already fixed with this fix:
commit c0a480d1acf7dc184f9f3e7cf724483b0d28dc2e
Author: Tony Lindgren [off-list ref]
Date: Fri Jul 28 01:23:15 2017 -0700
device property: Fix usecount for of_graph_get_port_parent()
No, that commit fixes it for of_graph_get_port_parent() while this
commit fixes it for of_fwnode_graph_get_port_parent(). But in essence it
is the same issue but needs two separate fixes.
--
Regards,
Niklas Söderlund