Re: [PATCH v3 1/3] omap3isp: Drop redundant isp->subdevs field and ISP_MAX_SUBDEVS
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Date: 2017-08-22 12:30:22
Also in:
linux-media
Hi Sakari, Thank you for the patch. On Friday, 18 August 2017 14:23:15 EEST Sakari Ailus wrote:
struct omap3isp.subdevs field and ISP_MAX_SUBDEVS macro are both unused. Remove them. Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
The field and macro are still used, you only remove them in patch 2/3. You can squash 1/3 and 2/3 together.
quoted hunk ↗ jump to hunk
--- drivers/media/platform/omap3isp/isp.h | 3 --- 1 file changed, 3 deletions(-)diff --git a/drivers/media/platform/omap3isp/isp.hb/drivers/media/platform/omap3isp/isp.h index e528df6efc09..848cd96b67ca 100644--- a/drivers/media/platform/omap3isp/isp.h +++ b/drivers/media/platform/omap3isp/isp.h@@ -220,9 +220,6 @@ struct isp_device { unsigned int sbl_resources; unsigned int subclk_resources; - -#define ISP_MAX_SUBDEVS 8 - struct v4l2_subdev *subdevs[ISP_MAX_SUBDEVS]; }; struct isp_async_subdev {
-- Regards, Laurent Pinchart