Thread (1 message) 1 message, 1 author, 2017-08-01

Re: [PATCH v2 3/3] Bluetooth: hci_bcm: Add serdev support

From: Sebastian Reichel <hidden>
Date: 2017-08-01 08:51:32
Also in: linux-bluetooth

Hi,

On Tue, Aug 01, 2017 at 10:38:24AM +0200, Loic Poulain wrote:
[...]
+	err = of_property_read_u32(serdev->dev.of_node, "max-speed", &speed);
+	if (!err)
+		bcmdev->hu.oper_speed = speed;
[...]
I suggest to use device_property_read_u32() here and include
<linux/property.h> instead of <linux/of.h>. This way the
serdev support is not DT specific.

-- Sebastian

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help