Re: [PATCH v3 1/2] gpio: davinci: Add keystone-k2g compatible
From: Vignesh R <hidden>
Date: 2017-08-01 06:12:49
Also in:
linux-arm-kernel, linux-gpio
On Monday 31 July 2017 07:14 PM, Keerthy wrote:
On Wednesday 26 July 2017 07:50 PM, Suman Anna wrote:quoted
On 07/26/2017 08:36 AM, Keerthy wrote:quoted
On Wednesday 26 July 2017 06:57 PM, Franklin S Cooper Jr wrote:quoted
On 07/26/2017 08:00 AM, Suman Anna wrote:quoted
Hi Keerthy, On 07/26/2017 01:45 AM, Keerthy wrote:quoted
The patch adds keystone-k2g compatible, specific properties and an example.
[...]
quoted
quoted
quoted
quoted
What about power-domain property?The correct name is "power-domains".quoted
Driver has no pm_runtime implemented yet.True, not yet, but this is in general a required property on K2G SoCs to automatically enable clocks through runtime_pm. Clock properties on K2G nodes should only be truly required if a driver is using clk API (ideally to control optional clocks or for adjusting clock frequencies). When the gpio-davinci driver gets updated to use pm_runtime, the clock properties will be rendered obsolete for K2G. Rob, Any suggestions on how we need to handle this? Should we be adding the property now or later when we adapt the driver for runtime_pm? This would be a common theme for K2G nodes that are reusing Davinci drivers. My take on this would be to add the property now, and mark the clock properties obsolete when the driver gets converted.
I don't think SoC wide properties are put into device specific binding documentation, for example pinctrl bindings are not put into device documentation.
Rob, Any comments on this?
[...] -- Regards Vignesh -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html