Re: [PATCH v9 1/2] serio: PS/2 gpio bit banging driver for serio bus
From: Linus Walleij <hidden>
Date: 2017-08-23 08:29:26
Also in:
linux-input, lkml
On Mon, Aug 21, 2017 at 9:31 PM, Danilo Krummrich [off-list ref] wrote:
+static int __ps2_gpio_write(struct serio *serio, unsigned char val) +static int ps2_gpio_write(struct serio *serio, unsigned char val)
I never like the random use of __prefixes as they have unclear semantics. I would name it something concise. Anyways, that is up to the subsystem maintainer.
From a GPIO point of view:
Reviewed-by: Linus Walleij <redacted> Yours, Linus Walleij