Thread (11 messages) 11 messages, 3 authors, 2017-08-30

Re: [PATCH v2 2/3] eeprom: at24: add support to fetch eeprom device property "size"

From: Sakari Ailus <sakari.ailus@iki.fi>
Date: 2017-08-22 09:13:26
Also in: linux-i2c, lkml

Hi Divagar,

On Tue, Aug 15, 2017 at 12:11:58AM +0530, Divagar Mohandass wrote:
This adds support to fetch device property "size" from _DSD.

There is a CAT24C16/GT24C16S NVMEM chip part of the OV13858
camera module and it is connected to i2c bus on Intel KBL board.
This device will use the existing ACPI ID INT3499 and platform
fw will expose "read-only", "pagesize" and "size" props via _DSD.
Instead of the two paragraphs, how about:

Obtain the size of the EEPROM chip from DT if the "size" property is
specified for the device.
quoted hunk ↗ jump to hunk
Signed-off-by: Divagar Mohandass <redacted>
---
 drivers/misc/eeprom/at24.c | 4 ++++
 1 file changed, 4 insertions(+)
diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c
index 764ff5df..2199c42 100644
--- a/drivers/misc/eeprom/at24.c
+++ b/drivers/misc/eeprom/at24.c
@@ -570,6 +570,10 @@ static void at24_get_pdata(struct device *dev, struct at24_platform_data *chip)
 	if (device_property_present(dev, "read-only"))
 		chip->flags |= AT24_FLAG_READONLY;
 
+	err = device_property_read_u32(dev, "size", &val);
+	if (!err)
+		chip->byte_len = val;
+
 	err = device_property_read_u32(dev, "pagesize", &val);
 	if (!err) {
 		chip->page_size = val;
-- 
1.9.1
-- 
Sakari Ailus
e-mail: sakari.ailus@iki.fi
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help