On Thu, Jul 6, 2017 at 10:18 AM, Rob Herring [off-list ref] wrote:

On Tue, Jun 27, 2017 at 02:23:20PM -0400, Al Cooper wrote:

quoted

Add Device Tree binding document for Broadcom USB Device
Controller (BDC).

Signed-off-by: Al Cooper <alcooperx@gmail.com>
---
 .../devicetree/bindings/usb/brcm,bdc-udc.txt       | 28

++++++++++++++++++++++

quoted

 1 file changed, 28 insertions(+)
 create mode 100644 Documentation/devicetree/

bindings/usb/brcm,bdc-udc.txt

quoted

diff --git a/Documentation/devicetree/bindings/usb/brcm,bdc-udc.txt

b/Documentation/devicetree/bindings/usb/brcm,bdc-udc.txt

quoted

new file mode 100644
index 0000000..4eeaddb

--- /dev/null
+++ b/Documentation/devicetree/bindings/usb/brcm,bdc-udc.txt

@@ -0,0 +1,28 @@
+Broadcom USB Device Controller (BDC)
+====================================
+
+Required properties:
+
+- compatible: must be one of:
+                "brcm,bdc-udc-v0.16"
+                "brcm,bdc-udc"

Isn't "bdc-udc" redundant?

I'll change the base name to "brcm-udc"

Where does the version number come from?

I comes from an API version number in one of the hardware controller
registers.

quoted

+- reg: the base register address and length
+- interrupts: ther interrupt line for this controller

s/ther/the/

Whoops, fixed.

quoted

+
+Optional properties:
+
+On Broadcom STB platforms, these properties are required:
+
+- phys: phandle to the USB PHY blocks

How many?

Either 1 or 2 depending on the Soc. I'll add a note to explain.

quoted

+- clocks: phandle to the functional clock of this block
+
+Example:
+
+        udc@f0b02000 {
+                status = "disabled";

Don't show status in examples.

Fixed

I'll re-send as v2 (including fix for "Also, "dt-bindings: usb: ..." for
the subject.")

Thanks
Al