Re: [PATCH 8/9] dt-bindings: iio: humidity: hts221: support open drain mode

On Sat, 15 Jul 2017 16:32:35 +0200
Lorenzo Bianconi [off-list ref] wrote:

quoted

On 11 July 2017 19:42:54 BST, Rob Herring [off-list ref] wrote:  

quoted

On Tue, Jul 11, 2017 at 1:26 PM, Jonathan Cameron [off-list ref]
wrote:  

quoted

On Mon, 10 Jul 2017 21:51:58 -0500
Rob Herring [off-list ref] wrote:
 

quoted

On Sun, Jul 09, 2017 at 06:57:03PM +0200, Lorenzo Bianconi wrote:  

quoted

Signed-off-by: Lorenzo Bianconi <redacted>
---
 Documentation/devicetree/bindings/iio/humidity/hts221.txt | 8  

++++++++  

quoted

quoted

quoted

 1 file changed, 8 insertions(+)

diff --git  

a/Documentation/devicetree/bindings/iio/humidity/hts221.txt
b/Documentation/devicetree/bindings/iio/humidity/hts221.txt  

quoted

quoted

quoted

index fca263e13400..732b83c06c08 100644

--- a/Documentation/devicetree/bindings/iio/humidity/hts221.txt
+++ b/Documentation/devicetree/bindings/iio/humidity/hts221.txt

@@ -5,6 +5,14 @@ Required properties:
 - reg: i2c address of the sensor / spi cs line

 Optional properties:
+- drive-open-drain: the interrupt/data ready line will be  

configured  

quoted

quoted

Needs a vendor prefix and "drdy-open-drain" would be more specific.  

This is straight out of the pinctrl bindings and has been used in a  

few  

quoted

other places as well.  I can see it should really be more obviously
associated with the drdy pin though.  A few IIO drivers already
use this binding (st sensors and the lsm6dsx).  If we are going
to decide it's a bad idea we should deprecate those bindings and
add whatever we do here as well.  

Ah, okay. Then the description should have a  "see pinctrl.txt" for
the description.  

Agreed.  

This property has been defined in pinctrl/pinctrl-bindings.txt. Is it
fine to refer to that file?
Regards,
Lorenzo

Yes, that's what Rob was effectively suggesting.

quoted

quoted

Rob
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html  

--
Sent from my Android device with K-9 Mail. Please excuse my brevity.