Em Wed, 19 Jul 2017 11:02:01 -0500
Rob Herring [off-list ref] escreveu:

On Wed, Jul 19, 2017 at 4:41 AM, Sylwester Nawrocki
[off-list ref] wrote:

quoted

On 07/18/2017 11:43 PM, Rob Herring wrote:  

quoted

Now that we have a custom printf format specifier, convert users of
full_name to use %pOF instead. This is preparation to remove storing
of the full path string for each node.

Signed-off-by: Rob Herring <robh@kernel.org>  

quoted

---
  drivers/media/i2c/s5c73m3/s5c73m3-core.c       |  3 +-
  drivers/media/i2c/s5k5baf.c                    |  7 ++--
  drivers/media/platform/am437x/am437x-vpfe.c    |  4 +-
  drivers/media/platform/atmel/atmel-isc.c       |  4 +-
  drivers/media/platform/davinci/vpif_capture.c  | 16 ++++----
  drivers/media/platform/exynos4-is/fimc-is.c    |  8 ++--
  drivers/media/platform/exynos4-is/fimc-lite.c  |  3 +-
  drivers/media/platform/exynos4-is/media-dev.c  |  8 ++--
  drivers/media/platform/exynos4-is/mipi-csis.c  |  4 +-
  drivers/media/platform/mtk-mdp/mtk_mdp_comp.c  |  6 +--
  drivers/media/platform/mtk-mdp/mtk_mdp_core.c  |  8 ++--
  drivers/media/platform/omap3isp/isp.c          |  8 ++--
  drivers/media/platform/pxa_camera.c            |  2 +-
  drivers/media/platform/rcar-vin/rcar-core.c    |  4 +-
  drivers/media/platform/soc_camera/soc_camera.c |  6 +--
  drivers/media/platform/xilinx/xilinx-vipp.c    | 52 +++++++++++++-------------
  drivers/media/v4l2-core/v4l2-async.c           |  4 +-
  drivers/media/v4l2-core/v4l2-clk.c             |  3 +-
  include/media/v4l2-clk.h                       |  4 +-
  19 files changed, 71 insertions(+), 83 deletions(-)  

quoted

diff --git a/drivers/media/platform/xilinx/xilinx-vipp.c b/drivers/media/platform/xilinx/xilinx-vipp.c
index ac4704388920..9233ad0b1b6b 100644
--- a/drivers/media/platform/xilinx/xilinx-vipp.c
+++ b/drivers/media/platform/xilinx/xilinx-vipp.c  

quoted

@@ -144,9 +144,8 @@ static int xvip_graph_build_one(struct xvip_composite_device *xdev,
              remote = ent->entity;

              if (link.remote_port >= remote->num_pads) {
-                     dev_err(xdev->dev, "invalid port number %u on %s\n",
-                             link.remote_port,
-                             to_of_node(link.remote_node)->full_name);
+                     dev_err(xdev->dev, "invalid port number %u on %pOF\n",
+                             link.remote_port, link.remote_node);  

Shouldn't there be to_of_node(link.remote_node) instead of link.remote_node ?  

Humm, yes. I thought I fixed that.

After such fix, I'm OK with this patch.

Are you planning to apply it on your tree, or via the media one?

I guess it is probably better to apply via media, in order to avoid
conflicts with other changes.

Thanks,
Mauro