Thread (27 messages) 27 messages, 6 authors, 2017-07-25

Re: [PATCH 1/4] gpio: davinci: Use devm_gpiochip_add_data in place of gpiochip_add_data

From: Keerthy <j-keerthy@ti.com>
Date: 2017-07-19 09:59:39
Also in: linux-arm-kernel, linux-gpio, lkml


On Wednesday 19 July 2017 03:07 PM, Johan Hovold wrote:
On Tue, Jul 18, 2017 at 04:27:13PM +0530, Keerthy wrote:
quoted
Use the devm version of gpiochip_add_data and pass on the
return value. Reset the static variables to 0 before returning.
You need to describe not just what you do, but also why you it. In this
case, your fixing memory leaks and the gpio chip being left registered
if this driver is unbound.
Sure i can add more description as mentioned above.
Johan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help