Thread (55 messages) 55 messages, 5 authors, 2017-07-17

Re: [PATCH 03/14] qcom: mtd: nand: Fixed config error for BCH

From: Abhishek Sahu <hidden>
Date: 2017-07-17 06:38:33
Also in: linux-arm-msm, lkml

On 2017-07-04 01:17, Boris Brezillon wrote:
On Thu, 29 Jun 2017 11:49:07 +0200
Marek Vasut [off-list ref] wrote:
quoted
On 06/29/2017 09:15 AM, Abhishek Sahu wrote:
quoted
The configuration for BCH is not correct in the current
driver so this patch fixed the same.
Fix the commit message, I have no idea what this patch does or fixes.
And please add a Fixes tag and Cc stable.
  Sure. I will amend the commit message to make it
  more clear and will include these tags.
quoted
quoted
Signed-off-by: Abhishek Sahu <redacted>
---
 drivers/mtd/nand/qcom_nandc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/qcom_nandc.c
b/drivers/mtd/nand/qcom_nandc.c
quoted
quoted
index 520add9..410ee53 100644
--- a/drivers/mtd/nand/qcom_nandc.c
+++ b/drivers/mtd/nand/qcom_nandc.c
@@ -1919,7 +1919,7 @@ static int qcom_nand_host_setup(struct
qcom_nand_host *host)
quoted
quoted
 				| wide_bus << WIDE_FLASH
 				| 1 << DEV0_CFG1_ECC_DISABLE;

-	host->ecc_bch_cfg = host->bch_enabled << ECC_CFG_ECC_DISABLE
+	host->ecc_bch_cfg = !host->bch_enabled << ECC_CFG_ECC_DISABLE
 				| 0 << ECC_SW_RESET
 				| host->cw_data << ECC_NUM_DATA_BYTES
 				| 1 << ECC_FORCE_CLK_OPEN
-- 
Abhishek Sahu
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help