Re: Submit of a driver for Pi433 - a radio module for Raspberry Pi
From: Greg KH <gregkh@linuxfoundation.org>
Date: 2017-07-16 06:45:53
Also in:
lkml
On Sat, Jul 15, 2017 at 07:05:04PM +0200, Wolf Entwicklungen wrote:
Am Sa, 15.07.2017, 15:47 schrieb Greg KH:quoted
On Sat, Jul 15, 2017 at 03:40:30PM +0200, Marcus Wolf wrote:quoted
Hi Greg,Hi Greg, now I added a TODO file and did a manual patchwork with lines of the old patch (git format-patch master --stdout -p > pi433_patch) and the newer patch (git diff master > pi433_patch). Stil don't know how to retreive multiple commits in one single patch directly from git :-/ I did my best to meet a lot of rules of the link, you send me.If there is stil something essential wrong or missing, please excuse and let me know. Especially I was in doubt about the verbosity of the change log. If you'd like to see the list of features of the driver over there (please see my first mail), let me know and I'll add.
Can you resend it without all of this stuff here, a patch email should just contain the patch itself, look at all of the examples on the mailing lists for how they look.
From: Marcus Wolf <redacted> Date: Tue,15 Jul 2017 17:52:06 +0100 Subject: [PATCH 1/1] drivers/staging/pi433: New driver Added a driver for the pi433 radio module (see https://www.pi433.de/en.html for details). Signed-off-by: Marcus Wolf <redacted>
Need a blank line before signed-off-by.
Tested-by: Marcus Wolf <redacted> on Raspbian, running Kernel v4.12
No need for a tested-by from something that wrote, that is implied :) Almost there... thanks, greg k-h