Re: [PATCH v4 4/4] dt-bindings: media: Document Synopsys Designware HDMI RX

Hi Rob,


On 10-07-2017 16:24, Rob Herring wrote:

On Mon, Jun 26, 2017 at 11:42 AM, Jose Abreu [off-list ref] wrote:

quoted

Hi Rob,


On 23-06-2017 22:58, Rob Herring wrote:

quoted

On Tue, Jun 20, 2017 at 06:26:12PM +0100, Jose Abreu wrote:

quoted

Document the bindings for the Synopsys Designware HDMI RX.

[...]

quoted

quoted

quoted

+A sample binding is now provided. The compatible string is for a SoC which has
+has a Synopsys Designware HDMI RX decoder inside.
+
+Example:
+
+dw_hdmi_soc: dw-hdmi-soc@0 {
+    compatible = "snps,dw-hdmi-soc";

Not documented.

Yes, its a sample binding which reflects a wrapper driver that
shall instantiate the controller driver (and this wrapper driver
is not in this patch series), should I remove this?

Ah, I see. Please don't do this wrapper node like what was done on
DWC3. It should be all one node with the SoC specific part being a new
compatible string (and maybe additional properties). If there's really
some custom logic around the IP block, then maybe it makes sense, but
if it is just different clock connections, phys, resets, etc. those
don't need a separate node.

Ok. I guess I can just drop the SoC specific bindings as this was
more of a sample as how the EDID handle can be specified. I just
sent v8 now with the new bindings :) Thanks!

Best regards,
Jose Miguel Abreu

Rob