Re: [PATCH v5 05/16] watchdog: lantiq: add device tree binding documentation
From: Rob Herring <hidden>
Date: 2017-06-23 22:05:08
Also in:
linux-mips, linux-spi, linux-watchdog
On Wed, Jun 21, 2017 at 12:37:32AM +0200, Hauke Mehrtens wrote:
quoted hunk
The binding was not documented before, add the documentation now. Signed-off-by: Hauke Mehrtens <hauke-5/S+JYg5SzeELgA04lAiVw@public.gmane.org> --- .../devicetree/bindings/watchdog/lantiq-wdt.txt | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) create mode 100644 Documentation/devicetree/bindings/watchdog/lantiq-wdt.txtdiff --git a/Documentation/devicetree/bindings/watchdog/lantiq-wdt.txt b/Documentation/devicetree/bindings/watchdog/lantiq-wdt.txt new file mode 100644 index 000000000000..1d41142ca55f --- /dev/null +++ b/Documentation/devicetree/bindings/watchdog/lantiq-wdt.txt@@ -0,0 +1,22 @@ +Lantiq WTD watchdog binding +============================ + +This describes the binding of the Lantiq watchdog driver. + +------------------------------------------------------------------------------- +Required properties: +- compatible : Should be one of + "lantiq,wdt" + "lantiq,xrx100-wdt" + "lantiq,falcon-wdt" +- regmap : A phandle to the RCU syscon (required for + "lantiq,falcon-wdt" and "lantiq,xrx100-wdt")
regmap is a Linuxism. I'd suggest "lantiq,rcu" instead.
+
+-------------------------------------------------------------------------------
+Example for the watchdog on the xRX200 SoCs:
+ watchdog@803f0 {
+ compatible = "lantiq,xrx100-wdt";Why did you remove the xrx200 compatible? You should add it to the compatible list (with the fallback).
+ reg = <0x803f0 0x10>; + + regmap = <&rcu0>; + }; -- 2.11.0
-- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html