Re: [RFC PATCH 2/3] drivers: misc: eeprom: at24: support reading mac eeprom from different addresses
From: Andy Shevchenko <hidden>
Date: 2017-06-29 11:56:10
Also in:
linux-i2c, lkml
From: Andy Shevchenko <hidden>
Date: 2017-06-29 11:56:10
Also in:
linux-i2c, lkml
On Thu, Jun 29, 2017 at 2:39 PM, Claudiu Beznea [off-list ref] wrote:
Add support for reading from different offsets of EEPROM. The offset is initialized via device tree. If nothing is given as input the old value, 0x90, is used. In this way the driver could be used as generic driver for different vendor memories by only changing the reading offset via device tree.
+ err = device_property_read_u8(dev, "start-offset", &chip->offset);
This property has to be documented. Moreover, the name looks too broad (I checked current use of "*-offset" type of properties and they either vendor specific, or data type specific. Taking above into consideration mac-offset sounds better to me. -- With Best Regards, Andy Shevchenko