Re: [PATCH 07/18] spi: qup: Fix transaction done signaling
From: Sricharan R <hidden>
Date: 2017-06-14 07:13:52
Also in:
linux-arm-msm, linux-spi, lkml
Hi Varada, On 6/14/2017 11:22 AM, Varadarajan Narayanan wrote:
quoted hunk ↗ jump to hunk
Wait to signal done until we get all of the interrupts we are expecting to get for a transaction. If we don't wait for the input done flag, we can be inbetween transactions when the done flag comes in and this can mess up the next transaction. Signed-off-by: Andy Gross <redacted> Signed-off-by: Varadarajan Narayanan <redacted> --- drivers/spi/spi-qup.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)diff --git a/drivers/spi/spi-qup.c b/drivers/spi/spi-qup.c index 2124815..7c22ee4 100644 --- a/drivers/spi/spi-qup.c +++ b/drivers/spi/spi-qup.c@@ -465,7 +465,8 @@ static irqreturn_t spi_qup_qup_irq(int irq, void *dev_id) controller->xfer = xfer; spin_unlock_irqrestore(&controller->lock, flags); - if (controller->rx_bytes == xfer->len || error) + if ((controller->rx_bytes == xfer->len && + (opflags & QUP_OP_MAX_INPUT_DONE_FLAG)) || error)
Not sure why we need this additional check, because having read all the bytes implies transfer complete (or) why not just check only for QUP_OP_MAX_INPUT_DONE_FLAG ? Regards, Sricharan -- "QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation