Re: [PATCH v4] mfd: lp87565: Add lp87565 PMIC support

On Monday 12 June 2017 02:57 PM, Javier Martinez Canillas wrote:

Hello Lee and Keerthy,

On Mon, Jun 12, 2017 at 11:17 AM, Keerthy [off-list ref] wrote:

quoted

On Monday 12 June 2017 02:41 PM, Lee Jones wrote:

quoted

On Sun, 11 Jun 2017, Keerthy wrote:

quoted

On Sunday 11 June 2017 10:36 AM, Keerthy wrote:

quoted

On Friday 09 June 2017 07:58 PM, Rob Herring wrote:

quoted

On Thu, Jun 08, 2017 at 09:38:14AM +0530, Keerthy wrote:

quoted

The LP87565 chip is a power management IC for Portable Navigation Systems
and Tablet Computing devices. It contains the following components:

        - Configurable Bucks(Single and multi-phase).
        - Configurable General Purpose Output Signals (GPO).

The LP87565-Q1 variant device uses two 2-phase outputs configuration,
Buck0 is master for Buck0/1 output and Buck2 is master for Buck2/3
output.

Lee Jones,

Shall i add back i2c_device_id as pointed here:
http://www.mail-archive.com/linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org/msg1417316.html

Hasn't that been fixed yet?

There are only 2 patch series remaining to be merged so we can finally
fix this in the I2C core, making sure that no drivers will be
regressed. One of the series is for MFD and have been around for a
while (it already contains all the relevant acks AFAICT), it would be
very helpful if you can look at it and merge if you think is correct:

https://lkml.org/lkml/2017/5/4/11

quoted

quoted

I guess so then. :(

Okay. So with that i assume i should reintroduce probe instead of probe_new.

It's orthogonal, you can have probe_new and also the I2C device ID
table (the OF table will be used for matching, you just need the I2C
table to export the aliases with MODULE_DEVICE_TABLE(i2c,.. ).

I believe the whole purpose of comments on probe_new was to remove the
i2c device ID. With that needed i will stick to probe for now and once
the above series mentioned by you gets in and all the dependencies for
probe_new are cleared i will send out a separate patch.

Best regards,
Javier

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html