Re: [PATCH v10 1/6] i2c: designware: Cleaning and comment style fixes.
From: Peter Rosin <hidden>
Date: 2017-06-09 08:57:53
Also in:
linux-i2c, lkml
From: Peter Rosin <hidden>
Date: 2017-06-09 08:57:53
Also in:
linux-i2c, lkml
On 2017-06-09 10:38, Andy Shevchenko wrote:
On Fri, 2017-06-09 at 07:12 +0200, Peter Rosin wrote:quoted
On 2017-06-08 19:36, Luis Oliveira wrote:quoted
@@ -984,12 +984,12 @@ int i2c_dw_probe(struct dw_i2c_dev *dev) } i2c_dw_disable_int(dev); - r = devm_request_irq(dev->dev, dev->irq, i2c_dw_isr,irq_flags, + ret = devm_request_irq(dev->dev, dev->irq, i2c_dw_isr, irq_flags, dev_name(dev->dev), dev);quoted
Two extra spaces needed to align with the opening bracket.It's a bikeshedding, though it looks like v11 is needed anyway (see kbuild bot complains), thus it might be addressed as well.
Bikeshedding or not, checkpatch.pl --strict notifies about the issue with: CHECK: Alignment should match open parenthesis Cheers, peda