Thread (92 messages) 92 messages, 7 authors, 2017-12-29

Re: [PATCH 04/15] clk: Add Ingenic jz4770 CGU driver

From: Paul Cercueil <paul@crapouillou.net>
Date: 2017-06-08 21:10:12
Also in: linux-clk, linux-mips, lkml

Hi,
quoted
+	register_syscore_ops(&jz4770_cgu_pm_ops);
+#endif
+}
+CLK_OF_DECLARE(jz4770_cgu, "ingenic,jz4770-cgu", jz4770_cgu_init);
Any reason this can't be a platform driver? Please add a comment
above CLK_OF_DECLARE describing what is preventing that.
It would probably be possible, if we cared about having a platform 
driver.
But we will only ever probe it from devicetree, just like with the
already existing jz4740-cgu and jz4780-cgu drivers.
quoted
diff --git a/include/dt-bindings/clock/jz4770-cgu.h 
b/include/dt-bindings/clock/jz4770-cgu.h
new file mode 100644
index 000000000000..54b8b2ae4a73
--- /dev/null
+++ b/include/dt-bindings/clock/jz4770-cgu.h
Can you split this file off into a different patch? That way clk
tree can apply clk patches on top of a stable branch where this
file lives by itself.
Sure.

Thanks,
- Paul
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help