Re: [PATCH 2/2] thermal: add brcmstb AVS TMON driver
From: Rafał Miłecki <rafal@milecki.pl>
Date: 2017-06-06 13:04:05
Also in:
linux-arm-kernel, linux-pm, lkml
On 2017-06-05 23:09, Markus Mayer wrote:
quoted hunk ↗ jump to hunk
--- /dev/null +++ b/drivers/thermal/broadcom/brcmstb_thermal.c@@ -0,0 +1,361 @@ +/* + * Broadcom STB AVS TMON thermal sensor driver + * + * Copyright (c) 2015-2017 Broadcom + * + * This software is licensed under the terms of the GNU General Public + * License version 2, as published by the Free Software Foundation,and + * may be copied, distributed, and modified under those terms. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + */
The headers says GPL v2 but it doesn't match MODULE_LICENSE. Please be consistent.
+/* Convert a HW code to a temperature reading (millidegree celsius) */
+static inline int avs_tmon_code_to_temp(u32 code)
+{
+ return (410040 - (int)((code & 0x3FF) * 487));
+}I got similar hardcoded values and Eduardo told me to move them to the DT. See discussion in: https://patchwork.kernel.org/patch/9642119/ Hint: thermal_zone_get_offset + thermal_zone_get_slope