Thread (69 messages) 69 messages, 7 authors, 2017-06-07

Re: [PATCH v7 16/34] [media] add Omnivision OV5640 sensor driver

From: Pavel Machek <hidden>
Date: 2017-06-03 19:51:44
Also in: linux-arm-kernel, linux-media, lkml

Hi!
quoted
quoted
quoted
+	/* Auto/manual exposure */
+	ctrls->auto_exp = v4l2_ctrl_new_std_menu(hdl, ops,
+						 V4L2_CID_EXPOSURE_AUTO,
+						 V4L2_EXPOSURE_MANUAL, 0,
+						 V4L2_EXPOSURE_AUTO);
+	ctrls->exposure = v4l2_ctrl_new_std(hdl, ops,
+					    V4L2_CID_EXPOSURE_ABSOLUTE,
+					    0, 65535, 1, 0);
Is exposure_absolute supposed to be in microseconds...?
Yes.
According to the docs V4L2_CID_EXPOSURE_ABSOLUTE is in 100 usec units.

 OTOH V4L2_CID_EXPOSURE has no defined unit, so it's a better fit IMO.
quoted
Way more drivers appear to be using EXPOSURE than EXPOSURE_ABSOLUTE, too.
Done, switched to V4L2_CID_EXPOSURE. It's true, this control is not
taking 100 usec units, so unit-less is better.
Thanks. If you know the units, it would be of course better to use
right units...

Best regards,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help