Re: [PATCH V2 4/5] dt-bindings: pinctrl: add imx7ulp pinctrl binding doc

On Sun, May 21, 2017 at 09:40:25AM +0000, A.S. Dong wrote:

quoted

-----Original Message-----
From: Shawn Guo [mailto:shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org]
Sent: Sunday, May 21, 2017 5:31 PM
To: A.S. Dong
Cc: linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org;
linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org; stefan-XLVq0VzYD2Y@public.gmane.org; Jacky Bai; Andy Duan;
kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org; Rob Herring; Mark Rutland;
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH V2 4/5] dt-bindings: pinctrl: add imx7ulp pinctrl
binding doc

On Fri, May 19, 2017 at 03:05:44PM +0800, Dong Aisheng wrote:

quoted

i.MX 7ULP has three IOMUXC instances: IOMUXC0 for M4 ports,
IOMUXC1 for A7 ports and IOMUXC DDR for DDR interface.

This patch adds the IOMUXC1 support for A7.

Cc: Rob Herring <redacted>
Cc: Mark Rutland <redacted>
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: Linus Walleij <redacted>
Cc: Shawn Guo <redacted>
Signed-off-by: Dong Aisheng <redacted>

---
ChangeLog:
v1->v2:
 * add more descriptions in binding doc
 * add missed prefix for private properties.
 * move dt-bindings/pinctrl/imx7ulp-pinfunc.h to arch/arm/boot/dts
---
 .../bindings/pinctrl/fsl,imx7ulp-pinctrl.txt       |  63 +++
 arch/arm/boot/dts/imx7ulp-pinfunc.h                | 468

+++++++++++++++++++++

Rather than being part of bindings doc patch, this pinfunc header should
be included in dts patches that add imx7ulp SoC support.

Okay.
One question is that imx7ulp-pinfunc.h is mentioned in this binding doc, 
that means after this patch applied, users still can't see it if separate,
Should we worry about this issue or not?
 
+       Refer to imx7ulp-pinfunc.h in in device tree source folder for all
+       available imx7ulp PIN_FUNC_ID.

Ah, okay, there is a reason to have it in the bindings doc patch.  If
LinusW and Rob have no problem with it, I'm fine then.

Acked-by: Shawn Guo <redacted>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html