Re: [PATCH v3 00/11] Broadcom Stingray SOC Initial Support
From: Florian Fainelli <f.fainelli@gmail.com>
Date: 2017-05-19 18:39:09
Also in:
linux-arm-kernel, linux-clk, lkml
On 05/16/2017 09:24 PM, Anup Patel wrote:
On Wed, May 17, 2017 at 12:23 AM, Olof Johansson [off-list ref] wrote:quoted
Hi, On Tue, May 16, 2017 at 4:30 AM, Anup Patel [off-list ref] wrote:quoted
This patchset adds initial support of Broadcom Stingray SOC by reusing existing Broadcom iProc device drivers. Most of the patches in this patchset are DT patches except the Stingray clock tree support which just one patch. This patchset is based on Linux-4.12-rc1 and it is also available at stingray-v3 branch of https://github.com/Broadcom/arm64-linux.git Changes since v2: - Remove default bootargs from chosen DT node - Remove "linux" prefix from stdout DT attribute of chosen DT node - Remove use of GIC_CPU_MASK_xxx() for PPIs Changes since v1: - Rebased patches for Linux-4.12-rc1 - Removed unwanted /memreserve/ from bcm958742-base.dtsi - Use ranges DT property to clear view of memory-layout - Make bcm-sr.h part of clock DT bindings patch Anup Patel (3): dt-bindings: bcm: Add Broadcom Stingray bindings document arm64: dts: Initial DTS files for Broadcom Stingray SOC arm64: dts: Add PL022, PL330 and SP805 DT nodes for Stingray Oza Pawandeep (1): arm64: dts: Add I2C DT nodes for Stingray SoC Pramod Kumar (3): arm64: dts: Add NAND DT nodes for Stingray SOC arm64: dts: Add pinctrl DT nodes for Stingray SOC arm64: dts: Add GPIO DT nodes for Stingray SOC Sandeep Tripathy (3): dt-bindings: clk: Extend binding doc for Stingray SOC clk: bcm: Add clocks for Stingray SOC arm64: dts: Add clock DT nodes for Stingray SOC Srinath Mannam (1): arm64: dts: Add PWM and SDHCI DT nodes for Stingray SOC .../devicetree/bindings/arm/bcm/brcm,stingray.txt | 12 + .../bindings/clock/brcm,iproc-clocks.txt | 76 ++++ arch/arm64/boot/dts/broadcom/Makefile | 1 + arch/arm64/boot/dts/broadcom/stingray/Makefile | 6 + .../boot/dts/broadcom/stingray/bcm958742-base.dtsi | 131 ++++++ .../boot/dts/broadcom/stingray/bcm958742k.dts | 78 ++++ .../boot/dts/broadcom/stingray/bcm958742t.dts | 40 ++ .../boot/dts/broadcom/stingray/stingray-clock.dtsi | 170 ++++++++ .../dts/broadcom/stingray/stingray-pinctrl.dtsi | 345 ++++++++++++++++ .../arm64/boot/dts/broadcom/stingray/stingray.dtsi | 460 +++++++++++++++++++++ drivers/clk/bcm/Kconfig | 8 + drivers/clk/bcm/Makefile | 1 + drivers/clk/bcm/clk-sr.c | 300 ++++++++++++++ include/dt-bindings/clock/bcm-sr.h | 101 +++++ .../dt-bindings/pinctrl/brcm,pinctrl-stingray.h | 68 +++ 15 files changed, 1797 insertions(+) create mode 100644 Documentation/devicetree/bindings/arm/bcm/brcm,stingray.txt create mode 100644 arch/arm64/boot/dts/broadcom/stingray/Makefile create mode 100644 arch/arm64/boot/dts/broadcom/stingray/bcm958742-base.dtsi create mode 100644 arch/arm64/boot/dts/broadcom/stingray/bcm958742k.dts create mode 100644 arch/arm64/boot/dts/broadcom/stingray/bcm958742t.dts create mode 100644 arch/arm64/boot/dts/broadcom/stingray/stingray-clock.dtsi create mode 100644 arch/arm64/boot/dts/broadcom/stingray/stingray-pinctrl.dtsi create mode 100644 arch/arm64/boot/dts/broadcom/stingray/stingray.dtsi create mode 100644 drivers/clk/bcm/clk-sr.c create mode 100644 include/dt-bindings/clock/bcm-sr.h create mode 100644 include/dt-bindings/pinctrl/brcm,pinctrl-stingray.hGrouping as one patchset for review is fine, but when you submit this for merge you need to split it up: - Documentation/devicetree can go with the driver pieces or with the DT changes, your choice - DTS/DTSI changes should go through the Broadcom maintainers to arm-soc - clk changes should go to clk maintainers.Only PATCH3 needs to go through clk maintainers rest all patches are DT bindings document and DTS changes which can go through Broadcom tree. Right ??
Patch 2 and 3 should go through the clock maintainers, and I can take the remaining patches through the Broadcom ARM/ARM64 SoC pull requests, no problem. Unless there are specific changes requested which warrant a v4, I can coordinate with Stephen and Mike to make sure that they take the appropriate patches.
quoted
Also, there's usually no need to split up a DT introduction and having separate pieces for NAND/pinctrl/GPIO/etc: They can all go in the main DT submission patch.Yes, we have already squashed DTS patches from same author into one DTS patch except NAND, PINCTRL and GPIO patches. The NAND, PINCTRL, and GPIO patches were not squashed into one patch for easy review but since you suggest I will squash these three DTS patches into one DTS patch. Regards, Anup
-- Florian