Re: Re: [PATCH 1/3] devicetree: add vendor prefix for Khadas
From: Gouwa <hidden>
Date: 2017-03-17 03:13:36
Hi, Martin & Rob:
Regarding Khadas and Wesion, we tend to keep them relatively independent, and as the commit on vendor-prefixes.txt, both following is okay:
+khadas Khadas
+khadas Khadas.com
We have corrected the misspellings of our company name on our website
from:
Shenzhen Wesion Technology CO.,LTD.
to:
Shenzhen Wesion Technology Co., Ltd.
Sorry for the trouble we made.
Something a little different~
Gouwa / 汪锋烽
Shenzhen Wesion Technology Co., Ltd.
深圳市世野科技有限公司
TEL: 0755-23076626
FAX: 0755-23076696
ADD: 深圳市宝安区宝源路名优采购中心C#301
From: Martin Blumenstingl
Date: 2017-03-17 05:14
To: Andreas Färber; Rob Herring; gouwa
CC: mark.rutland; devicetree; narmstrong; khilman; will.deacon; catalin.marinas; carlo; linux-amlogic; linux-arm-kernel; jbrunet
Subject: Re: [PATCH 1/3] devicetree: add vendor prefix for Khadas
On Thu, Mar 16, 2017 at 7:00 AM, Andreas Färber [off-list ref] wrote:Am 15.03.2017 um 20:57 schrieb Rob Herring:quoted
On Sat, Mar 04, 2017 at 10:51:24PM +0100, Martin Blumenstingl wrote:quoted
Khadas is a new sub-brand of Shenzhen Wesion Technology CO.,LTD. They are developing Amlogic and Rockchip based "DIY boxes" (single board computers): http://khadas.com/ They are best know for their latest product: the Khadas VIM (an Amlogic GXL S905X based SBC). Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> --- Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + 1 file changed, 1 insertion(+)Acked-by: Rob Herring <robh@kernel.org>Shouldn't the entry reflect what is in the commit message rather than just repeat the prefix? I.e., something like "Khadas by Shenzhen Wesion Technology Co., Ltd." (which I believe is the official spelling and spacing of these abbreviations also for the commit message).
I took the spelling for "Shenzhen Wesion Technology CO.,LTD." from their website: [0]
An Acked-by from the CC'ed vendor would also be desirable. :)
I asked Gouwa, one of the people behind the Khadas VIM boards for clarification some time ago: "Khadas is a new brand power by Shenzhen Wesion Technology, 'Khadas' is brand, 'VIM' is product serial name, like 'Apple + iPhone'" I think I used the vendor-prefixes "pine64" and "radxa" as reference (see [1]) when I wrote the patch - and none of the existing entries seems to follow the "brand by parent company" schema. @Gouwa, Rob: could you please share your opinion on what the official "vendor" name for the "khadas" prefix should be? Regards, Martin [0] http://szwesion.com/contact/ [1] http://lxr.free-electrons.com/source/Documentation/devicetree/bindings/vendor-prefixes.txt