Thread (4 messages) 4 messages, 4 authors, 2017-03-29

RE: [PATCH v2 2/7] rtc: Add rtc-sh

From: Chris Brandt <Chris.Brandt@renesas.com>
Date: 2017-03-29 14:14:20
Also in: linux-renesas-soc, linux-rtc

Possibly related (same subject, not in this thread)

On Wednesday, March 29, 2017, Geert Uytterhoeven wrote:
quoted
quoted
+Example:
+rtc: rtc@fcff1000 {
+     compatible = "renesas,r7s72100-rtc", "renesas,sh-rtc";
+     reg = <0xfcff1000 0x2e>;
+     interrupts = <GIC_SPI 276 IRQ_TYPE_EDGE_RISING
+                   GIC_SPI 277 IRQ_TYPE_EDGE_RISING
+                   GIC_SPI 278 IRQ_TYPE_EDGE_RISING>;
+     interrupt-names = "alarm", "period", "carry";
+     clocks = <&mstp6_clks R7S72100_CLK_RTC>, <&rtc_x1_clk>,
+              <&rtc_x3_clk>, <&extal_clk>;
+     clock-names = "fck", "rtc_x1", "rtc_x3", "extal";
+     power-domains = <&cpg_clocks>;
Not documented.
"power-domains" is a platform property.

All hardware components need power.
All synchronous hardware components need a clock.
Most hardware components have a reset signal.

Whether these are exposed and can be controlled depends on the
platform/SoC.
So documenting them in each and every device binding looks overkill to me.
I think this is something to be addressed by devicetree-specification
(which doesn't handle clocks, power-domains, resets yet).

If you prefer, the property can be removed from the example, though.
I'll go ahead and pull it out (since I have to update the commit title
anyway as per Rob's request)

Besides...it's probably the most least important part of the example ;)

Thanks,
Chris
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help